[AGENT++] Identical code blocks in MibTable::commit_set_request()

[Frank Fock]

Hi Hugo,

Yes, the code is redundant. I will simplify it for the next release.
Thanks for reporting it!

Best regards,
Frank

Hugo Krapf wrote:

>Hi Frank,
>As I was browsing the sources, I've noticed that the if and else blocks inside
>MibTable::commit_set_request() are identical.  I guess that's due to historical reasons.
>But as the code stands today we end up running find() twice, since MibTable::set_value() also calls find().
>I think we could safely remove the if (find(req->get_oid(ind))) { in MibTable::commit_set_request().
>Best regards,
>Hugo.
>
>
>_______________________________________________
>AGENTPP mailing list
>AGENTPP at agentpp.org
>http://lists.agentpp.org/mailman/listinfo/agentpp
>
>  
>