[AGENT++] Question on SET processing

[Fehde, Marcus]

Hi Frank,
This seems a little bit confusing to me. Why do I have to free resources either in UNDO or in CLEANUP? Why isn't CLEANUP called in any case so that I've a central point for freeing resources? Furthermore a see that UNDO is called on VBs which were not committed.
Example: Multiple varbind request with VB0 VB1 VB2
* VB0 - VB2 are prepared
* VB0 is comitted
* VB1 commit fails
* VB2 is not comitted
* VB0 - VB2 is undone !!
This causes undoing the not committed VB2. I would expect that UNDO is only called on VBs which were previously committed and following this that CLEANUP is called anyway to have a clear situation for freeing resources. May be I didn't get the point so what's the philosophy behind your approach?
-Marcus


-----Original Message-----
From: Frank Fock [mailto:fock at agentpp.com] 
Sent: Freitag, 15. Juli 2005 08:08
To: Fehde, Marcus
Cc: Agent++ Mailing List
Subject: Re: [AGENT++] Question on SET processing

Hi Marcus,
This behavior is intended, since a UNDO is always the last step in a 2PC, it should also free resources. A good implementation approach is to implement a method for freeing the resources and call it from both the UNDO and the CLEANUP.
Best regards,
Frank
Fehde, Marcus wrote:
>Hi @ all,
>
>I have a question regarding the SET-request processing phases and the
>invocation of the associated of MibEntry undo_set_request()-method. I 
>observe that if the COMMIT fails UNDO is called, but CLEANUP is 
>omitted. This behavior is not comprehensible for me. I would expect 
>that I'm always freeing allocated resources in the 
>cleanup_set_request()-method. Otherwise I would have to free resources 
>in undo_set_request() as well, depending on the passed phases of the 
>SET processing. Is this behavior intended?
>
>
>Best regards/Mit freundlichen Gruessen
>Marcus Fehde
>Dipl. Ing. Technische Informatik (FH)
>Research & Development
>Business Unit Anaesthesia 
>_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
>DRÄGER MEDICAL 
>Dräger Medical AG & Co. KGaA 
>Moislinger Allee 53-55 
>D-23542 Lübeck 
>Tel: + 49-451-882-3646 
>Fax: + 49-451-882-4410 
>E-mail: marcus.fehde at draeger.com 
>www.draeger-medical.com 
>_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
>_______________________________________________
>AGENTPP mailing list
>AGENTPP at agentpp.org
>http://lists.agentpp.org/mailman/listinfo/agentpp
>
>
> 
>



Best regards/Mit freundlichen Gruessen 
Marcus Fehde
Dipl. Ing. Technische Informatik (FH)
Research & Development 
Business Unit Anaesthesia 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
DRÄGER MEDICAL 
Dräger Medical AG & Co. KGaA 
Moislinger Allee 53-55 
D-23542 Lübeck 
Tel:  + 49-451-882-3646 
Fax: + 49-451-882-4410 
E-mail: marcus.fehde at draeger.com 
www.draeger-medical.com 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _