[SNMP4J] Bug in MessageDispatcherImpl.getNextRequestID() in SNMP4J v1.5 (part II)

[Esteban José García Zamora]

Hello again.

I'm sorry, but in my yesterday mail reporting the bug I introduce another bug.

Evidently nextTransactionID must hold the value to return next time method is invoked, and this is 2, not 1.
So, the correct bug repair is to replace line:

145         nextID = 1;

by:

145         nextID = 1;
146         nextTransactionID = 2;

Thanks

  ----- Original Message ----- 
  From: Esteban José García Zamora 
  To: snmp4j at agentpp.org 
  Sent: Wednesday, July 20, 2005 1:26 PM
  Subject: Bug in MessageDispatcherImpl.getNextRequestID() in SNMP4J v1.5 


  Hello.

  getNextRequestID() in MessageDispacherImpl.java have an error.
  If nextTransactionID becomes negative, the method will return 1 for all the negative values in nextTransactionID.
  There will be necessary to change line:

  145         nextID = 1;

  by this one:

  145         nextTransactionID = nextID = 1;

  And that's all.

  By the way. Congratulations for your great work making this snmp package.


  Esteban.