[SNMP4J] printStackTrace in Mpv3

[Frank Fock]

Hello Imre,

Thanks for the hint! I have added the isDebugEnabled()
wrapper.

Best regards,
Frank

Imre Kovács wrote:
> Hello Frank,
> 
> 
> 
> This is just a small notification which I wanted to make earlier, but it is
> never too late…
> 
> 
> 
> So, in the MPv3.java, at row 996, there is the following:
> 
> 
> 
> catch (IOException iox) {
> 
>          logger.warn("ASN.1 parse error: "+iox.getMessage());
> 
>          iox.printStackTrace();
> ...
> 
> 
> I saw, that many places you use the printStackTrace, but only in
> 
> 
> 
> if (logger.isDebugEnabled()) {
> 
>        iox.printStackTrace();
> 
>      }
> 
> 
> 
> form.
> 
> 
> 
> So, I know, that it makes sense to know that the message cannot be decoded,
> but it may not be logged directly to the console with the trace as well.
> 
> 
> 
> Best regards,
> 
> Imre Kovacs
> _______________________________________________
> SNMP4J mailing list
> SNMP4J at agentpp.org
> http://lists.agentpp.org/mailman/listinfo/snmp4j

-- 
AGENT++
http://www.agentpp.com
http://www.mibexplorer.com
http://www.mibdesigner.com