[SNMP4J] DefaultTcpTransportMapping.SocketEnry.nextMessage() needs to be synchronized

[Sachs, Larry]

Hi Frank,

 

Just like DefaultTcpTransportMapping.SocketEnry.addMessage(),
DefaultTcpTransportMapping.SocketEnry.nextMessage() needs to be
synchronized.  In our multi-threaded app I've seen this occasionally:

 

2007-09-21 07:30:17,660 [DefaultTCPTransportMapping_134.242.164.192/0]
WARN  taskexecutor Encountered unhandled exception

java.util.NoSuchElementException

        at java.util.LinkedList.remove(LinkedList.java:644)

        at java.util.LinkedList.removeFirst(LinkedList.java:134)

        at
com.ncube.nable.app.subagent.DefaultTcpTransportMapping$SocketEntry.next
Message(DefaultTcpTransportMapping.java:393)

        at
com.ncube.nable.app.subagent.DefaultTcpTransportMapping$ServerThread.wri
teMessage(DefaultTcpTransportMapping.java:887)

        at
com.ncube.nable.app.subagent.DefaultTcpTransportMapping$ServerThread.run
(DefaultTcpTransportMapping.java:672)

 

 

Thanks,

ls