[SNMP4J] Possible bug in TableUtils

[Smith, Gary]

Hi Frank

 

I think there is a possible bug in TableUtils (1.10.2).

 

In TableRequest.onResponse(...) there is a flag to determine if any
request OIDs were matched to response OIDs, anyMatchInChunk.

 

However, this is being initialised to false within the for() rows loop
(line 436) which means it is really an "any match in current row for
chunk" flag.  But, also, this is then only being checked _outside_ the
for() rows loop (line 511) which means, effectively, it is an "any match
in _last_ row for chunk" flag.

 

This doesn't look like it is doing what was intended.

 

However, it does appear to be working as it stands because, once all
rows have been retrieved, OID mismatches will occur, causing skipping of
the row processing (line 445). Despite the fact that some rows may have
been added to rowCache, anyMatch remains false (line 511), and so
rowCache is ultimately flushed & finished in the else section (line
531).

 

Despite this it looks as if something is awry, what do you think?

 

 

Regards

 

Gary



Please be advised that this email may contain confidential information.
 If you are not the intended recipient, please do not read, copy or
re-transmit this email.  If you have received this email in error,
please notify us by email by replying to the sender and by telephone
(call us collect at +1 202-828-0850) and delete this message and any
attachments.  Thank you in advance for your cooperation and assistance.

In addition, Danaher and its subsidiaries disclaim that the content of
this email constitutes an offer to enter into, or the acceptance of, 
any
contract or agreement or any amendment thereto; provided that the
foregoing disclaimer does not invalidate the binding effect of any
digital or other electronic reproduction of a manual signature that is
included in any attachment to this email.