[SNMP4J] Statistics about number of retries and snmp request times

[Frank Fock]

Hi Michal,

I will add the Javadoc (you can find the full documentation already in 
the SNMP4J-STATISTICS-MIB.txt file
in the mibs directory of the SNMP4J ZIP file).
The size queue size accessor will be added too.
I have chosen 1/100s instead of millis because the Counter64 will take 
10-times longer to overflow (wrap)
and I do not think that millis are important to that statistic. Even on 
a fast system the typical wait time
will be more than 5ms.

For the process time ms could be more precise that is true.

OK, in order to have the same unit for both time measure  counters, I 
will change the unit to ms.

Best regards,
Frank

Am 25.01.2016 um 17:19 schrieb Michał Steiner:
> Hi
> Here is my quick feedback just from looking at code:
>
> It would be very helpful to see Javadoc with explanation what event 
> below mean exactly
>
>   // SNMP4J-STATISTICS-MIB
> snmp4jStatsRequestTimeouts
> snmp4jStatsRequestRetries
> snmp4jStatsRequestWaitTime
> snmp4jStatsResponseTimeouts
> snmp4jStatsResponseIgnoredRetries
> snmp4jStatsResponseProcessTime
>
> Also in what time unit there are given - I noticed 
>  constant HUNDREDTHS_TO_NANOSECOND (tenth of milliseconds BTW why not 
> ms  ?)
>
> Javadoc for org.snmp4j.Snmp#getCounterSupport   is 
> missing snmp4jStatsRequestRetries but it has 
> duplicated snmp4jStatsRequestTimeouts.
>
>
> Also I think it would be very useful from monitoring perspective to 
> publish size of  collections: pendingRequests and asyncRequests. It 
> would be enough to create two getters calling pendingRequests .size() 
> and asyncRequests.size()
>
> Regards
> Michal
>

-- 
---
AGENT++
Maximilian-Kolbe-Str. 10
73257 Koengen, Germany
https://agentpp.com
Phone: +49 7024 8688230
Fax:   +49 7024 8688231