[AGENT++] [PATCH] agent++: (several simple patches)

Jochen Katz katz at agentpp.com
Sun Aug 15 21:55:22 CEST 2010


Hi,

>   The patch to remove "#pragma interface" I reported earlier.

I let this to Frank, to accept it or not.

>   Also clean core files named like core.12345.
>   Add install rules like in snmp++.

Accepted.

>   Fix some compiler warnings (unused variables).

This happens if _NO_LOGGING is defined. I will try to find a better
solution than your workaround.

>   Correct a comment that claimed that ThreadList was a singleton.

I let this to Frank, because ThreadList is used as a singleton within
agent++.

>   Make the destructor of MibGroub virtual since it is a base
>   class.  Althoug it does not matter at the moment, it's better to
>   make the destructor virtual to avoid future problems.

Accepted, but I just learned that it is not needed as the base class
already has a virtual destructor. Therefore the compiler does not
complain about "class has virtual functions but non-virtual destructor".

Regards,
  Jochen



More information about the AGENTPP mailing list